Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify vanus operator default endpoint #589

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: modify vanus operator default endpoint #589

wants to merge 2 commits into from
+51 −87

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@hwjiangkai hwjiangkai requested a review from ifplusor April 3, 2023 11:30
@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Merging #589 (3efd1f2) into main (ee76217) will decrease coverage by 2.35%.
The diff coverage is 46.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   57.07%   54.72%   -2.35%     
==========================================
  Files         190      211      +21     
  Lines       15191    16917    +1726     
==========================================
+ Hits         8670     9258     +588     
- Misses       5884     6961    +1077     
- Partials      637      698      +61
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
internal/gateway/proxy/proxy.go 23.23% <ø> (+0.14%) ⬆️
internal/gateway/proxy/reigister.go 100.00% <ø> (ø)
internal/gateway/proxy/util.go 0.00% <ø> (ø)
...nternal/primitive/authentication/authentication.go 34.09% <ø> (ø)
internal/primitive/authentication/client.go 0.00% <ø> (ø)
internal/primitive/authorization/action.go 0.00% <ø> (ø)
... and 71 more

... and 55 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f90ea26...3efd1f2. Read the comment docs.

@ifplusor ifplusor added the co/vsctl relating to vsctl label Apr 12, 2023
@ifplusor ifplusor marked this pull request as draft June 2, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifplusor ifplusor Awaiting requested review from ifplusor ifplusor is a code owner

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
co/vsctl relating to vsctl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwjiangkai @ifplusor